Diff: modules/pico_dhcp_server.c

Revision:

131:4758606c9316

Parent:

70:cd218dd180e5

Child:

141:fb35b52d1c80

--- a/modules/pico_dhcp_server.c	Wed Dec 11 07:20:17 2013 +0000
+++ b/modules/pico_dhcp_server.c	Mon Dec 16 11:25:54 2013 +0100
@@ -1,10 +1,10 @@
 /*********************************************************************
-PicoTCP. Copyright (c) 2012 TASS Belgium NV. Some rights reserved.
-See LICENSE and COPYING for usage.
+   PicoTCP. Copyright (c) 2012 TASS Belgium NV. Some rights reserved.
+   See LICENSE and COPYING for usage.
 
 
-Authors: Frederik Van Slycken, Kristof Roelants
-*********************************************************************/
+   Authors: Frederik Van Slycken, Kristof Roelants
+ *********************************************************************/
 
 #ifdef PICO_SUPPORT_DHCPD
 #include "pico_dhcp_server.h"
@@ -15,10 +15,10 @@
 #include "pico_stack.h"
 #include "pico_arp.h"
 
-#define dhcps_dbg(...) do{}while(0)
-//#define dhcps_dbg dbg
+#define dhcps_dbg(...) do {} while(0)
+/* #define dhcps_dbg dbg */
 
-/* default configurations */ 
+/* default configurations */
 #define DHCP_SERVER_OPENDNS    long_be(0xd043dede) /* OpenDNS DNS server 208.67.222.222 */
 #define DHCP_SERVER_POOL_START long_be(0x00000064)
 #define DHCP_SERVER_POOL_END   long_be(0x000000fe)
@@ -30,288 +30,317 @@
 #define ip_inrange(x) ((long_be(x) >= long_be(dhcpn->dhcps->pool_start)) && (long_be(x) <= long_be(dhcpn->dhcps->pool_end)))
 
 enum dhcp_server_state {
-  PICO_DHCP_STATE_DISCOVER = 0,
-  PICO_DHCP_STATE_OFFER,
-  PICO_DHCP_STATE_REQUEST,
-  PICO_DHCP_STATE_BOUND,
-  PICO_DHCP_STATE_RENEWING
+    PICO_DHCP_STATE_DISCOVER = 0,
+    PICO_DHCP_STATE_OFFER,
+    PICO_DHCP_STATE_REQUEST,
+    PICO_DHCP_STATE_BOUND,
+    PICO_DHCP_STATE_RENEWING
 };
 
 struct pico_dhcp_server_negotiation {
-  uint32_t xid;
-  enum dhcp_server_state state;
-  struct pico_dhcp_server_setting *dhcps;
-  struct pico_ip4 ciaddr;
-  struct pico_eth hwaddr;
+    uint32_t xid;
+    enum dhcp_server_state state;
+    struct pico_dhcp_server_setting *dhcps;
+    struct pico_ip4 ciaddr;
+    struct pico_eth hwaddr;
 };
 
 static void pico_dhcpd_wakeup(uint16_t ev, struct pico_socket *s);
 
 static int dhcp_settings_cmp(void *ka, void *kb)
 {
-  struct pico_dhcp_server_setting *a = ka, *b = kb;
-  if (a->dev == b->dev)
-    return 0;
-  return (a->dev < b->dev) ? -1 : 1;
-} 
+    struct pico_dhcp_server_setting *a = ka, *b = kb;
+    if (a->dev == b->dev)
+        return 0;
+
+    return (a->dev < b->dev) ? -1 : 1;
+}
 PICO_TREE_DECLARE(DHCPSettings, dhcp_settings_cmp);
 
 static int dhcp_negotiations_cmp(void *ka, void *kb)
 {
-  struct pico_dhcp_server_negotiation *a = ka, *b = kb;
-  if (a->xid == b->xid)
-    return 0;
-  return (a->xid < b->xid) ? -1 : 1;
-} 
+    struct pico_dhcp_server_negotiation *a = ka, *b = kb;
+    if (a->xid == b->xid)
+        return 0;
+
+    return (a->xid < b->xid) ? -1 : 1;
+}
 PICO_TREE_DECLARE(DHCPNegotiations, dhcp_negotiations_cmp);
 
 static struct pico_dhcp_server_setting *pico_dhcp_server_add_setting(struct pico_dhcp_server_setting *setting)
 {
-  uint16_t port = PICO_DHCPD_PORT;
-  struct pico_dhcp_server_setting *dhcps = NULL, *found = NULL, test = {0};
-  struct pico_ipv4_link *link = NULL;
-  
-  link = pico_ipv4_link_get(&setting->server_ip);
-  if (!link) {
-    pico_err = PICO_ERR_EINVAL;
-    return NULL;
-  }
-  test.dev = setting->dev;
-  found = pico_tree_findKey(&DHCPSettings, &test);
-  if (found) {
-    pico_err = PICO_ERR_EINVAL;
-    return NULL;
-  }
-  dhcps = pico_zalloc(sizeof(struct pico_dhcp_server_setting));
-  if (!dhcps) {
-    pico_err = PICO_ERR_ENOMEM;
-    return NULL;
-  }
+    uint16_t port = PICO_DHCPD_PORT;
+    struct pico_dhcp_server_setting *dhcps = NULL, *found = NULL, test = {
+        0
+    };
+    struct pico_ipv4_link *link = NULL;
+
+    link = pico_ipv4_link_get(&setting->server_ip);
+    if (!link) {
+        pico_err = PICO_ERR_EINVAL;
+        return NULL;
+    }
+
+    test.dev = setting->dev;
+    found = pico_tree_findKey(&DHCPSettings, &test);
+    if (found) {
+        pico_err = PICO_ERR_EINVAL;
+        return NULL;
+    }
+
+    dhcps = pico_zalloc(sizeof(struct pico_dhcp_server_setting));
+    if (!dhcps) {
+        pico_err = PICO_ERR_ENOMEM;
+        return NULL;
+    }
 
-  dhcps->lease_time = setting->lease_time;
-  dhcps->pool_start = setting->pool_start;
-  dhcps->pool_next = setting->pool_next;
-  dhcps->pool_end = setting->pool_end;
-  dhcps->dev = link->dev;
-  dhcps->server_ip = link->address;
-  dhcps->netmask = link->netmask;
+    dhcps->lease_time = setting->lease_time;
+    dhcps->pool_start = setting->pool_start;
+    dhcps->pool_next = setting->pool_next;
+    dhcps->pool_end = setting->pool_end;
+    dhcps->dev = link->dev;
+    dhcps->server_ip = link->address;
+    dhcps->netmask = link->netmask;
+
+    /* default values if not provided */
+    if (!dhcps->pool_start)
+        dhcps->pool_start = (dhcps->server_ip.addr & dhcps->netmask.addr) | DHCP_SERVER_POOL_START;
+
+    if (!dhcps->pool_end)
+        dhcps->pool_end = (dhcps->server_ip.addr & dhcps->netmask.addr) | DHCP_SERVER_POOL_END;
+
+    if (!dhcps->lease_time)
+        dhcps->lease_time = DHCP_SERVER_LEASE_TIME;
 
-  /* default values if not provided */
-  if (!dhcps->pool_start)
-    dhcps->pool_start = (dhcps->server_ip.addr & dhcps->netmask.addr) | DHCP_SERVER_POOL_START;
-  if (!dhcps->pool_end)
-    dhcps->pool_end = (dhcps->server_ip.addr & dhcps->netmask.addr) | DHCP_SERVER_POOL_END;
-  if (!dhcps->lease_time)
-    dhcps->lease_time = DHCP_SERVER_LEASE_TIME;
-  dhcps->pool_next = dhcps->pool_start;
+    dhcps->pool_next = dhcps->pool_start;
+
+    dhcps->s = pico_socket_open(PICO_PROTO_IPV4, PICO_PROTO_UDP, &pico_dhcpd_wakeup);
+    if (!dhcps->s) {
+        dhcps_dbg("DHCP server ERROR: failure opening socket (%s)\n", strerror(pico_err));
+        pico_free(dhcps);
+        return NULL;
+    }
 
-  dhcps->s = pico_socket_open(PICO_PROTO_IPV4, PICO_PROTO_UDP, &pico_dhcpd_wakeup);
-  if (!dhcps->s) {
-    dhcps_dbg("DHCP server ERROR: failure opening socket (%s)\n", strerror(pico_err));
-    pico_free(dhcps);
-    return NULL;
-  }
-  if (pico_socket_bind(dhcps->s, &dhcps->server_ip, &port) < 0) {
-    dhcps_dbg("DHCP server ERROR: failure binding socket (%s)\n", strerror(pico_err));
-    pico_free(dhcps);
-    return NULL;
-  }
-  
-  pico_tree_insert(&DHCPSettings, dhcps);
-  return dhcps;
+    if (pico_socket_bind(dhcps->s, &dhcps->server_ip, &port) < 0) {
+        dhcps_dbg("DHCP server ERROR: failure binding socket (%s)\n", strerror(pico_err));
+        pico_free(dhcps);
+        return NULL;
+    }
+
+    pico_tree_insert(&DHCPSettings, dhcps);
+    return dhcps;
 }
 
 static struct pico_dhcp_server_negotiation *pico_dhcp_server_find_negotiation(uint32_t xid)
 {
-  struct pico_dhcp_server_negotiation test = {0}, *found = NULL;
+    struct pico_dhcp_server_negotiation test = {
+        0
+    }, *found = NULL;
 
-  test.xid = xid;
-  found = pico_tree_findKey(&DHCPNegotiations, &test);
-  if (found)
-    return found;
-  else
-    return NULL;
+    test.xid = xid;
+    found = pico_tree_findKey(&DHCPNegotiations, &test);
+    if (found)
+        return found;
+    else
+        return NULL;
 }
 
 static struct pico_dhcp_server_negotiation *pico_dhcp_server_add_negotiation(struct pico_device *dev, struct pico_dhcp_hdr *hdr)
 {
-  struct pico_dhcp_server_negotiation *dhcpn = NULL;
-  struct pico_dhcp_server_setting test = {0};
-  struct pico_ip4 *ciaddr = NULL;
+    struct pico_dhcp_server_negotiation *dhcpn = NULL;
+    struct pico_dhcp_server_setting test = {
+        0
+    };
+    struct pico_ip4 *ciaddr = NULL;
 
-  if (pico_dhcp_server_find_negotiation(hdr->xid))
-    return NULL;
+    if (pico_dhcp_server_find_negotiation(hdr->xid))
+        return NULL;
 
-  dhcpn = pico_zalloc(sizeof(struct pico_dhcp_server_negotiation));
-  if (!dhcpn) {
-    pico_err = PICO_ERR_ENOMEM;
-    return NULL;
-  }
+    dhcpn = pico_zalloc(sizeof(struct pico_dhcp_server_negotiation));
+    if (!dhcpn) {
+        pico_err = PICO_ERR_ENOMEM;
+        return NULL;
+    }
 
-  dhcpn->xid = hdr->xid;
-  dhcpn->state = PICO_DHCP_STATE_DISCOVER;
-  memcpy(dhcpn->hwaddr.addr, hdr->hwaddr, PICO_SIZE_ETH);
+    dhcpn->xid = hdr->xid;
+    dhcpn->state = PICO_DHCP_STATE_DISCOVER;
+    memcpy(dhcpn->hwaddr.addr, hdr->hwaddr, PICO_SIZE_ETH);
 
-  test.dev = dev;
-  dhcpn->dhcps = pico_tree_findKey(&DHCPSettings, &test);
-  if (!dhcpn->dhcps) {
-    dhcps_dbg("DHCP server WARNING: received DHCP message on unconfigured link %s\n", dev->name);
-    pico_free(dhcpn);
-    return NULL;
-  }
+    test.dev = dev;
+    dhcpn->dhcps = pico_tree_findKey(&DHCPSettings, &test);
+    if (!dhcpn->dhcps) {
+        dhcps_dbg("DHCP server WARNING: received DHCP message on unconfigured link %s\n", dev->name);
+        pico_free(dhcpn);
+        return NULL;
+    }
 
-  ciaddr = pico_arp_reverse_lookup(&dhcpn->hwaddr);
-  if (!ciaddr) {
-    dhcpn->ciaddr.addr = dhcpn->dhcps->pool_next;
-    dhcpn->dhcps->pool_next = long_be(long_be(dhcpn->dhcps->pool_next) + 1);
-    pico_arp_create_entry(dhcpn->hwaddr.addr, dhcpn->ciaddr, dhcpn->dhcps->dev);
-  } else {
-    dhcpn->ciaddr = *ciaddr;
-  }
+    ciaddr = pico_arp_reverse_lookup(&dhcpn->hwaddr);
+    if (!ciaddr) {
+        dhcpn->ciaddr.addr = dhcpn->dhcps->pool_next;
+        dhcpn->dhcps->pool_next = long_be(long_be(dhcpn->dhcps->pool_next) + 1);
+        pico_arp_create_entry(dhcpn->hwaddr.addr, dhcpn->ciaddr, dhcpn->dhcps->dev);
+    } else {
+        dhcpn->ciaddr = *ciaddr;
+    }
 
-  pico_tree_insert(&DHCPNegotiations, dhcpn);
-  return dhcpn; 
+    pico_tree_insert(&DHCPNegotiations, dhcpn);
+    return dhcpn;
 }
 
 static void dhcpd_make_reply(struct pico_dhcp_server_negotiation *dhcpn, uint8_t msg_type)
 {
-  int r = 0, optlen = 0, offset = 0;
-  struct pico_ip4 broadcast = {0}, dns = {0}, destination = { .addr = 0xFFFFFFFF};
-  struct pico_dhcp_hdr *hdr = NULL;
+    int r = 0, optlen = 0, offset = 0;
+    struct pico_ip4 broadcast = {
+        0
+    }, dns = {
+        0
+    }, destination = {
+        .addr = 0xFFFFFFFF
+    };
+    struct pico_dhcp_hdr *hdr = NULL;
 
-  dns.addr = DHCP_SERVER_OPENDNS;
-  broadcast.addr = dhcpn->dhcps->server_ip.addr | ~(dhcpn->dhcps->netmask.addr);
+    dns.addr = DHCP_SERVER_OPENDNS;
+    broadcast.addr = dhcpn->dhcps->server_ip.addr | ~(dhcpn->dhcps->netmask.addr);
 
-  optlen = PICO_DHCP_OPTLEN_MSGTYPE + PICO_DHCP_OPTLEN_SERVERID + PICO_DHCP_OPTLEN_LEASETIME + PICO_DHCP_OPTLEN_NETMASK + PICO_DHCP_OPTLEN_ROUTER 
-          + PICO_DHCP_OPTLEN_BROADCAST + PICO_DHCP_OPTLEN_DNS + PICO_DHCP_OPTLEN_END;
-  hdr = pico_zalloc(sizeof(struct pico_dhcp_hdr) + (uint32_t)optlen);
+    optlen = PICO_DHCP_OPTLEN_MSGTYPE + PICO_DHCP_OPTLEN_SERVERID + PICO_DHCP_OPTLEN_LEASETIME + PICO_DHCP_OPTLEN_NETMASK + PICO_DHCP_OPTLEN_ROUTER
+             + PICO_DHCP_OPTLEN_BROADCAST + PICO_DHCP_OPTLEN_DNS + PICO_DHCP_OPTLEN_END;
+    hdr = pico_zalloc(sizeof(struct pico_dhcp_hdr) + (uint32_t)optlen);
 
-  hdr->op = PICO_DHCP_OP_REPLY;
-  hdr->htype = PICO_DHCP_HTYPE_ETH;
-  hdr->hlen = PICO_SIZE_ETH;
-  hdr->xid = dhcpn->xid;
-  hdr->yiaddr = dhcpn->ciaddr.addr;
-  hdr->siaddr = dhcpn->dhcps->server_ip.addr;
-  hdr->dhcp_magic = PICO_DHCPD_MAGIC_COOKIE;
-  memcpy(hdr->hwaddr, dhcpn->hwaddr.addr, PICO_SIZE_ETH);
+    hdr->op = PICO_DHCP_OP_REPLY;
+    hdr->htype = PICO_DHCP_HTYPE_ETH;
+    hdr->hlen = PICO_SIZE_ETH;
+    hdr->xid = dhcpn->xid;
+    hdr->yiaddr = dhcpn->ciaddr.addr;
+    hdr->siaddr = dhcpn->dhcps->server_ip.addr;
+    hdr->dhcp_magic = PICO_DHCPD_MAGIC_COOKIE;
+    memcpy(hdr->hwaddr, dhcpn->hwaddr.addr, PICO_SIZE_ETH);
 
-  /* options */
-  offset += pico_dhcp_opt_msgtype(&hdr->options[offset], msg_type);
-  offset += pico_dhcp_opt_serverid(&hdr->options[offset], &dhcpn->dhcps->server_ip);
-  offset += pico_dhcp_opt_leasetime(&hdr->options[offset], dhcpn->dhcps->lease_time);
-  offset += pico_dhcp_opt_netmask(&hdr->options[offset], &dhcpn->dhcps->netmask);
-  offset += pico_dhcp_opt_router(&hdr->options[offset], &dhcpn->dhcps->server_ip);
-  offset += pico_dhcp_opt_broadcast(&hdr->options[offset], &broadcast);
-  offset += pico_dhcp_opt_dns(&hdr->options[offset], &dns);
-  offset += pico_dhcp_opt_end(&hdr->options[offset]);
+    /* options */
+    offset += pico_dhcp_opt_msgtype(&hdr->options[offset], msg_type);
+    offset += pico_dhcp_opt_serverid(&hdr->options[offset], &dhcpn->dhcps->server_ip);
+    offset += pico_dhcp_opt_leasetime(&hdr->options[offset], dhcpn->dhcps->lease_time);
+    offset += pico_dhcp_opt_netmask(&hdr->options[offset], &dhcpn->dhcps->netmask);
+    offset += pico_dhcp_opt_router(&hdr->options[offset], &dhcpn->dhcps->server_ip);
+    offset += pico_dhcp_opt_broadcast(&hdr->options[offset], &broadcast);
+    offset += pico_dhcp_opt_dns(&hdr->options[offset], &dns);
+    offset += pico_dhcp_opt_end(&hdr->options[offset]);
 
-  destination.addr = hdr->yiaddr;
-  r = pico_socket_sendto(dhcpn->dhcps->s, hdr, (int)(sizeof(struct pico_dhcp_hdr) + (uint32_t)optlen), &destination, PICO_DHCP_CLIENT_PORT);
-  if (r < 0)
-    dhcps_dbg("DHCP server WARNING: failure sending: %s!\n", strerror(pico_err));
+    destination.addr = hdr->yiaddr;
+    r = pico_socket_sendto(dhcpn->dhcps->s, hdr, (int)(sizeof(struct pico_dhcp_hdr) + (uint32_t)optlen), &destination, PICO_DHCP_CLIENT_PORT);
+    if (r < 0)
+        dhcps_dbg("DHCP server WARNING: failure sending: %s!\n", strerror(pico_err));
 
-  return;
+    return;
 }
 
 static void pico_dhcp_server_recv(struct pico_socket *s, uint8_t *buf, uint32_t len)
 {
-  uint8_t msgtype = 0;
-  int32_t optlen = (int32_t)(len - sizeof(struct pico_dhcp_hdr));
-  struct pico_dhcp_hdr *hdr = (struct pico_dhcp_hdr *)buf;
-  struct pico_dhcp_opt *opt = (struct pico_dhcp_opt *)hdr->options;
-  struct pico_dhcp_server_negotiation *dhcpn = NULL;
-  struct pico_ip4 reqip = {0}, server_id = {0};
-  struct pico_device *dev = NULL;
+    uint8_t msgtype = 0;
+    int32_t optlen = (int32_t)(len - sizeof(struct pico_dhcp_hdr));
+    struct pico_dhcp_hdr *hdr = (struct pico_dhcp_hdr *)buf;
+    struct pico_dhcp_opt *opt = (struct pico_dhcp_opt *)hdr->options;
+    struct pico_dhcp_server_negotiation *dhcpn = NULL;
+    struct pico_ip4 reqip = {
+        0
+    }, server_id = {
+        0
+    };
+    struct pico_device *dev = NULL;
 
-  if (!pico_dhcp_are_options_valid(hdr->options, optlen))
-    return;
+    if (!pico_dhcp_are_options_valid(hdr->options, optlen))
+        return;
+
+    dev = pico_ipv4_link_find(&s->local_addr.ip4);
+    dhcpn = pico_dhcp_server_find_negotiation(hdr->xid);
+    if (!dhcpn)
+        dhcpn = pico_dhcp_server_add_negotiation(dev, hdr);
+
+    if (!ip_inrange(dhcpn->ciaddr.addr))
+        return;
+
+    do {
+        switch (opt->code)
+        {
+        case PICO_DHCP_OPT_PAD:
+            break;
 
-  dev = pico_ipv4_link_find(&s->local_addr.ip4);
-  dhcpn = pico_dhcp_server_find_negotiation(hdr->xid);
-  if (!dhcpn)
-    dhcpn = pico_dhcp_server_add_negotiation(dev, hdr);
- 
-  if (!ip_inrange(dhcpn->ciaddr.addr))
-    return;
+        case PICO_DHCP_OPT_END:
+            break;
+
+        case PICO_DHCP_OPT_MSGTYPE:
+            msgtype = opt->ext.msg_type.type;
+            dhcps_dbg("DHCP server: message type %u\n", msgtype);
+            break;
+
+        case PICO_DHCP_OPT_REQIP:
+            reqip = opt->ext.req_ip.ip;
+            dhcps_dbg("DHCP server: requested IP %08X\n", reqip.addr);
+            break;
 
-  do {
-    switch (opt->code)
-    {
-      case PICO_DHCP_OPT_PAD:
-        break;
+        case PICO_DHCP_OPT_SERVERID:
+            server_id = opt->ext.server_id.ip;
+            dhcps_dbg("DHCP server: server ID %08X\n", server_id.addr);
+            break;
 
-      case PICO_DHCP_OPT_END:
-        break;
+        default:
+            dhcps_dbg("DHCP server WARNING: unsupported option %u\n", opt->code);
+            break;
+        }
+    } while (pico_dhcp_next_option(&opt));
 
-      case PICO_DHCP_OPT_MSGTYPE:
-        msgtype = opt->ext.msg_type.type;
-        dhcps_dbg("DHCP server: message type %u\n", msgtype);
+    switch (msgtype)
+    {
+    case PICO_DHCP_MSG_DISCOVER:
+        dhcpd_make_reply(dhcpn, PICO_DHCP_MSG_OFFER);
+        dhcpn->state = PICO_DHCP_STATE_OFFER;
         break;
 
-      case PICO_DHCP_OPT_REQIP:
-        reqip = opt->ext.req_ip.ip;
-        dhcps_dbg("DHCP server: requested IP %08X\n", reqip.addr);
+    case PICO_DHCP_MSG_REQUEST:
+        if ((dhcpn->state == PICO_DHCP_STATE_BOUND) && (!reqip.addr) && (!server_id.addr) && (hdr->ciaddr == dhcpn->ciaddr.addr))
+            dhcpd_make_reply(dhcpn, PICO_DHCP_MSG_ACK);
+
+        if (dhcpn->state == PICO_DHCP_STATE_OFFER) {
+            dhcpn->state = PICO_DHCP_STATE_BOUND;
+            dhcpd_make_reply(dhcpn, PICO_DHCP_MSG_ACK);
+        }
+
         break;
 
-      case PICO_DHCP_OPT_SERVERID:
-        server_id = opt->ext.server_id.ip;
-        dhcps_dbg("DHCP server: server ID %08X\n", server_id.addr);
-        break;        
-
-      default:
-        dhcps_dbg("DHCP server WARNING: unsupported option %u\n", opt->code);
+    default:
+        dhcps_dbg("DHCP server WARNING: unsupported message type %u\n", msgtype);
         break;
     }
-  } while (pico_dhcp_next_option(&opt));
-
-  switch (msgtype)
-  {
-    case PICO_DHCP_MSG_DISCOVER:
-      dhcpd_make_reply(dhcpn, PICO_DHCP_MSG_OFFER);
-      dhcpn->state = PICO_DHCP_STATE_OFFER;
-      break;
-
-    case PICO_DHCP_MSG_REQUEST:
-      if ((dhcpn->state == PICO_DHCP_STATE_BOUND) && (!reqip.addr) && (!server_id.addr) && (hdr->ciaddr == dhcpn->ciaddr.addr))
-        dhcpd_make_reply(dhcpn, PICO_DHCP_MSG_ACK);
-      if (dhcpn->state == PICO_DHCP_STATE_OFFER) {
-        dhcpn->state = PICO_DHCP_STATE_BOUND;
-        dhcpd_make_reply(dhcpn, PICO_DHCP_MSG_ACK);
-      }
-      break;
-
-    default:
-      dhcps_dbg("DHCP server WARNING: unsupported message type %u\n", msgtype);
-      break;
-  }
-  return;
+    return;
 }
 
 static void pico_dhcpd_wakeup(uint16_t ev, struct pico_socket *s)
 {
-  uint8_t buf[DHCP_SERVER_MAXMSGSIZE] = {0};
-  int r = 0;
+    uint8_t buf[DHCP_SERVER_MAXMSGSIZE] = {
+        0
+    };
+    int r = 0;
 
-  if (ev != PICO_SOCK_EV_RD)
+    if (ev != PICO_SOCK_EV_RD)
+        return;
+
+    r = pico_socket_recvfrom(s, buf, DHCP_SERVER_MAXMSGSIZE, NULL, NULL);
+    if (r < 0)
+        return;
+
+    pico_dhcp_server_recv(s, buf, (uint32_t)r);
     return;
-  r = pico_socket_recvfrom(s, buf, DHCP_SERVER_MAXMSGSIZE, NULL, NULL);
-  if (r < 0)
-    return;
-
-  pico_dhcp_server_recv(s, buf, (uint32_t)r);
-  return;
 }
 
 int pico_dhcp_server_initiate(struct pico_dhcp_server_setting *setting)
 {
-  if (!setting || !setting->server_ip.addr) {
-    pico_err = PICO_ERR_EINVAL;
-    return -1;
-  }
+    if (!setting || !setting->server_ip.addr) {
+        pico_err = PICO_ERR_EINVAL;
+        return -1;
+    }
 
-  if (pico_dhcp_server_add_setting(setting) == NULL)
-    return -1;
+    if (pico_dhcp_server_add_setting(setting) == NULL)
+        return -1;
 
-  return 0;
+    return 0;
 }
 #endif /* PICO_SUPPORT_DHCP */