Karl Zweimüller / mRotaryEncoder

Important changes to repositories hosted on mbed.com

Mbed hosted mercurial repositories are deprecated and are due to be permanently deleted in July 2026.

To keep a copy of this software download the repository Zip archive or clone locally using Mercurial.

It is also possible to export all your personal repositories from the account settings page.

Dependencies:   PinDetect

Dependents:   SimplePIDBot FinalProgram VS1053Player SPK-DVIMXR ... more

M J.

Issue: Deconstructor may fail?

Hi, don't you think that you should have an "if" before deleting the pins?

mRotaryEncoder::mRotaryEncoder() { if(m_pinA) delete m_pinA; if(m_pinB) delete m_pinB; if(m_pinSW) delete m_pinSW; }

2 comments:

M J.
04 Dec 2019

And for sure initializing the variables in the constructor before assigning the pins.

mRotaryEncoder::mRotaryEncoder(PinName pinA, PinName pinB, PinName pinSW, PinMode pullMode, int debounceTime_us):m_pinA(NULL), m_pinB(NULL),  m_pinSW(NULL)
M J.
04 Dec 2019

I answer myself. You don't need if before delete.