MODIFIED from mbed official WiflyInterface (interface for Roving Networks Wifly modules). Numerous performance and reliability improvements (see the detailed documentation). Also, tracking changes in mbed official version to retain functional parity.

Dependents:   Smart-WiFly-WebServer PUB_WiflyInterface_Demo

Fork of WiflyInterface by mbed official

Resources

Derivative from mbed Official

  • Documentation update, improved consistency, documented parameters that were inadvertently omitted.
  • Avoid c++ string handling, which causes dynamic allocation and free, side effect, fewer CPU cycles spent for same purpose.
  • Fixed socket APIs to support non-blocking mode.
  • Increase communication baud-rate to Wifly module
  • sendCommand - added retries for improved robustness.
  • setConnectionState - method to force the connection state (used by TCPSocketServer)
  • gethostbyname - added a length parameter to the size of the buffer being written
  • flushIn - a private method to flush the input buffer
  • Changed the timeout from 500 to 2500 msec for commands - measured some at 700 to 850 msec.
  • Performance improvements - reduced some unnecessary delays.
  • Added additional security options for the wi-fi connection (that are supported by the WiFly module).
  • Added setSecurity API which permits revising the security when connecting to, or selecting from, one of several access points.
  • Improved DEBUG interface (slightly more consistent printout).
  • gathers information from the Wifly module on reboot (SW version info), which permits customizing behavior based on Wifly capabilities (like the improved security).
  • Avoid potential for recursive crash (if exit fails, it calls sendcommand, which calls exit...)
  • Update to support permissible SSID and PassCode lengths.

Robustness testing

I've had some mixed behavior with the Wifly module, some of which seems to be traceable to the module itself, and some in my derivative code. The result, after running for minutes, hours, sometimes days, it hangs and I have to reset the module.

To test, I created a fairly simple test program -

  • check for Watchdog induced reset and count it.
  • initialize the Watchdog for 60 sec timeout.
  • Init the Wifly interface and connect to my network.
  • Wait 10 seconds and force mbed_reset().

If the Watchdog induces the restart, then it is pretty clear that either:

  • The communications hung with the Wifly module causing the failure.
  • The Wifly module decided to go unresponsive.

If it gets to the end, it typically takes about 4 to 6 seconds for the boot and connect, then the 10 second delay.

But I can't really pin down the root cause easily. My strongest theory is that the Wifly module has rebooted, and since I don't store the high baud rate I configure it for, it resets back to 9600.

Also, one of the objectives for my revised send( ) is to avoid the c++ string, as that can fragment memory, and it wasn't very well bounded in behavior.

Latest tests:

Warm BootsWatchdog EventsNotes
100's30An early version of my derivative WiflyInterface, including my derivative of "send( )" API. Let's call this version 0.1.
26684My derivative WiflyInterface, but with the mbed official "send( )" API. Much improved. This was over the course of about 12 hours.
24003Most recent derivative - incremental change to "send( )", but this relative number does not rule out the Wifly module itself.

I think with these numbers, +/- 1 means that the changes have had no measurable effect. Which is good, since this incremental change eliminates the c++ string handling.

Test Software

This is pieces of a test program, clipped and copied to here. What I have compiled and run for hours and hours is almost exactly what you see. This uses this simple Watchdog library.

#include "mbed.h"
#include "WiflyInterface.h"
#include "Watchdog.h"

Serial pc(USBTX, USBRX);

Watchdog wd;
extern "C" void mbed_reset();

// Pinout for SmartBoard
WiflyInterface wifly(p9, p10, p30, p29, "ssid", "pass", WPA);

int main() {
    pc.baud(460800);                         // I like a snappy terminal
    
    wd.Configure(60.0);                     // Set time limit for the test to 1 minute
    LPC_RTC->GPREG0++;                      // Count boots here
    if (wd.WatchdogCausedReset()) {
        LPC_RTC->GPREG1++;                  // Count Watchdog events here
        pc.printf("\r\n\r\nWatchdog event.\r\n");
    }
    pc.printf("\r\nWifly Test: %d boots, %d watchdogs. %s %s\r\n", LPC_RTC->GPREG0, LPC_RTC->GPREG1, __DATE__, __TIME__);
    
    wifly.init(); // use DHCP
    pc.printf("Connect...  ");
    while (!wifly.connect());               // join the network
    pc.printf("Address is %s.  ", wifly.getIPAddress());
    pc.printf("Disconnect...  ");
    wifly.disconnect();
    pc.printf("OK. Reset in 10 sec...\r\n");
    wait(10);
    if (pc.readable()) {
        if (pc.getc() == 'r') {             // secret 'r'eset of the counters
            LPC_RTC->GPREG0 = 0;
            LPC_RTC->GPREG1 = 0;
            pc.printf("counters reset\r\n");
        }
    }
    mbed_reset();                           // reset here indicates successful communication
}
Committer:
WiredHome
Date:
Sat Dec 19 19:16:58 2015 +0000
Revision:
72:9499f5c1e00b
Parent:
67:557ea7ad15c1
Child:
73:59d0bbc4f905
Improve API compatibility with EthernetInterface, even when that means some APIs return a failure-code, since WiflyInterface cannot do all that EthernetInterface can.

Who changed what in which revision?

UserRevisionLine numberNew contents of line
WiredHome 51:a4831b1cb9a4 1 #include "WiflyInterface.h"
WiredHome 51:a4831b1cb9a4 2
WiredHome 51:a4831b1cb9a4 3 WiflyInterface::WiflyInterface( PinName tx, PinName rx, PinName reset, PinName tcp_status,
WiredHome 51:a4831b1cb9a4 4 const char * ssid, const char * phrase, Security sec) :
WiredHome 51:a4831b1cb9a4 5 Wifly(tx, rx, reset, tcp_status, ssid, phrase, sec)
WiredHome 51:a4831b1cb9a4 6 {
WiredHome 51:a4831b1cb9a4 7 ip_set = false;
WiredHome 72:9499f5c1e00b 8 mac_set = false;
WiredHome 51:a4831b1cb9a4 9 }
WiredHome 51:a4831b1cb9a4 10
WiredHome 51:a4831b1cb9a4 11 int WiflyInterface::init()
WiredHome 51:a4831b1cb9a4 12 {
WiredHome 51:a4831b1cb9a4 13 state.dhcp = true;
WiredHome 72:9499f5c1e00b 14 ip_set = false;
WiredHome 51:a4831b1cb9a4 15 reset();
WiredHome 67:557ea7ad15c1 16 configure();
WiredHome 51:a4831b1cb9a4 17 return 0;
WiredHome 51:a4831b1cb9a4 18 }
WiredHome 51:a4831b1cb9a4 19
WiredHome 51:a4831b1cb9a4 20 int WiflyInterface::init(const char* ip, const char* mask, const char* gateway)
WiredHome 51:a4831b1cb9a4 21 {
WiredHome 51:a4831b1cb9a4 22 state.dhcp = false;
WiredHome 51:a4831b1cb9a4 23 this->ip = ip;
WiredHome 51:a4831b1cb9a4 24 strcpy(ip_string, ip);
WiredHome 51:a4831b1cb9a4 25 ip_set = true;
WiredHome 51:a4831b1cb9a4 26 this->netmask = mask;
WiredHome 51:a4831b1cb9a4 27 this->gateway = gateway;
WiredHome 51:a4831b1cb9a4 28 reset();
WiredHome 67:557ea7ad15c1 29 configure();
WiredHome 51:a4831b1cb9a4 30 return 0;
WiredHome 51:a4831b1cb9a4 31 }
WiredHome 51:a4831b1cb9a4 32
WiredHome 51:a4831b1cb9a4 33 void WiflyInterface::setSecurity(const char * ssid, const char * phrase, Security sec)
WiredHome 51:a4831b1cb9a4 34 {
WiredHome 51:a4831b1cb9a4 35 Wifly::SetSecurity(ssid, phrase, sec);
WiredHome 45:21b7bbaad62b 36 }
WiredHome 51:a4831b1cb9a4 37
WiredHome 51:a4831b1cb9a4 38 int WiflyInterface::connect()
WiredHome 51:a4831b1cb9a4 39 {
WiredHome 63:fee0b25f1bf5 40 return (join()) ? 0 : -1;
WiredHome 51:a4831b1cb9a4 41 }
WiredHome 51:a4831b1cb9a4 42
WiredHome 51:a4831b1cb9a4 43 int WiflyInterface::disconnect()
WiredHome 51:a4831b1cb9a4 44 {
WiredHome 72:9499f5c1e00b 45 ip_set = false;
WiredHome 51:a4831b1cb9a4 46 return Wifly::disconnect();
WiredHome 51:a4831b1cb9a4 47 }
WiredHome 51:a4831b1cb9a4 48
WiredHome 72:9499f5c1e00b 49 // command "get mac\r"
WiredHome 72:9499f5c1e00b 50 // response "MAC Addr=##:##:##:##:##:##\n<4.40> "
WiredHome 72:9499f5c1e00b 51 char * WiflyInterface::getMACAddress()
WiredHome 72:9499f5c1e00b 52 {
WiredHome 72:9499f5c1e00b 53 char buffer[50];
WiredHome 72:9499f5c1e00b 54 char * match = buffer;
WiredHome 72:9499f5c1e00b 55 char * p;
WiredHome 72:9499f5c1e00b 56 if (!mac_set) {
WiredHome 72:9499f5c1e00b 57 ip_string[0] = '\0';
WiredHome 72:9499f5c1e00b 58 if (!sendCommand("get mac\r", NULL, buffer))
WiredHome 72:9499f5c1e00b 59 return NULL;
WiredHome 72:9499f5c1e00b 60 exit();
WiredHome 72:9499f5c1e00b 61 flush();
WiredHome 72:9499f5c1e00b 62 // revised to find the mac address string, following a small
WiredHome 72:9499f5c1e00b 63 // change where \r are permitted in the captured
WiredHome 72:9499f5c1e00b 64 // reply to a command.
WiredHome 72:9499f5c1e00b 65 while (*match && (*match != '='))
WiredHome 72:9499f5c1e00b 66 match++;
WiredHome 72:9499f5c1e00b 67 if (*match) {
WiredHome 72:9499f5c1e00b 68 match++; // Advance past '='
WiredHome 72:9499f5c1e00b 69 p = match;
WiredHome 72:9499f5c1e00b 70 while (strchr("0123456789abcdefABCDEF:", *p))
WiredHome 72:9499f5c1e00b 71 p++;
WiredHome 72:9499f5c1e00b 72 *p = '\0';
WiredHome 72:9499f5c1e00b 73 if (strlen(match) <= 17) { // 192.168.101.202
WiredHome 72:9499f5c1e00b 74 strcpy(mac_string, match);
WiredHome 72:9499f5c1e00b 75 mac_set = true;
WiredHome 72:9499f5c1e00b 76 }
WiredHome 72:9499f5c1e00b 77 }
WiredHome 72:9499f5c1e00b 78 }
WiredHome 72:9499f5c1e00b 79 return ip_string;
WiredHome 72:9499f5c1e00b 80 }
WiredHome 72:9499f5c1e00b 81
WiredHome 51:a4831b1cb9a4 82 // typical response might be
WiredHome 51:a4831b1cb9a4 83 // \r192.168.43.107\r
WiredHome 51:a4831b1cb9a4 84 // <4.40>
WiredHome 51:a4831b1cb9a4 85 char * WiflyInterface::getIPAddress()
WiredHome 51:a4831b1cb9a4 86 {
WiredHome 65:427518ba7b01 87 char buffer[50];
WiredHome 65:427518ba7b01 88 char * match = buffer;
WiredHome 65:427518ba7b01 89 char * p;
WiredHome 51:a4831b1cb9a4 90 if (!ip_set) {
WiredHome 65:427518ba7b01 91 if (!sendCommand("get ip a\r", NULL, buffer))
WiredHome 51:a4831b1cb9a4 92 return NULL;
WiredHome 51:a4831b1cb9a4 93 exit();
WiredHome 51:a4831b1cb9a4 94 flush();
WiredHome 51:a4831b1cb9a4 95 // revised to find the IP string, following a small
WiredHome 51:a4831b1cb9a4 96 // change where \r are permitted in the captured
WiredHome 51:a4831b1cb9a4 97 // reply to a command.
WiredHome 51:a4831b1cb9a4 98 while (*match && (*match < '0' || *match > '9'))
WiredHome 51:a4831b1cb9a4 99 match++;
WiredHome 65:427518ba7b01 100 p = match;
WiredHome 65:427518ba7b01 101 while (strchr("0123456789.", *p))
WiredHome 65:427518ba7b01 102 p++;
WiredHome 65:427518ba7b01 103 *p = '\0';
WiredHome 65:427518ba7b01 104 if (strlen(match) <= 15) { // 192.168.101.202
WiredHome 65:427518ba7b01 105 strcpy(ip_string, match);
WiredHome 65:427518ba7b01 106 ip_set = true;
WiredHome 65:427518ba7b01 107 }
WiredHome 51:a4831b1cb9a4 108 }
WiredHome 51:a4831b1cb9a4 109 return ip_string;
WiredHome 51:a4831b1cb9a4 110 }
WiredHome 72:9499f5c1e00b 111
WiredHome 72:9499f5c1e00b 112
WiredHome 72:9499f5c1e00b 113 int WiflyInterface::setName(const char * myname)
WiredHome 72:9499f5c1e00b 114 {
WiredHome 72:9499f5c1e00b 115 (void)myname; // unsupported at this time...
WiredHome 72:9499f5c1e00b 116 return 0; // indicate success...
WiredHome 72:9499f5c1e00b 117 }
WiredHome 72:9499f5c1e00b 118
WiredHome 72:9499f5c1e00b 119 const char * WiflyInterface::getName(void)
WiredHome 72:9499f5c1e00b 120 {
WiredHome 72:9499f5c1e00b 121 return NULL;
WiredHome 72:9499f5c1e00b 122 }