Important changes to repositories hosted on mbed.com
Mbed hosted mercurial repositories are deprecated and are due to be permanently deleted in July 2026.
To keep a copy of this software download the repository Zip archive or clone locally using Mercurial.
It is also possible to export all your personal repositories from the account settings page.
Dependents: PwmOscillator FastStepDriver TLC5940 CameraTest ... more
Issue: check if duty is < 0 or > 1
void FastPWM::write(double duty) {
_duty=duty;
pulsewidth_ticks(duty*getPeriod());
}
I think this (and maybe pulsewidth functions too) should check for values as to remain in the 0.0 - 1.0 range
And a BIG THANKS man!
Hey,
In general the goal of FastPWM is besides to have increased resolution, to also have good performance. So not always there will be checks and instead it is a job for the user to use the correct values.
That said, this function isn't exactly time critical, since a double multiplication isn't fast anyway, so a comparison shouldn't be much overhead. I will add it soonish :). Or alternatively, you are also welcome to make a pull request :D.
Thanks.
Erik