Diff: Devices/DS2482_DS2484.cpp

Revision:

7:471901a04573

Parent:

6:a8c83a2e6fa4

--- a/Devices/DS2482_DS2484.cpp	Wed Jan 23 13:11:04 2019 -0600
+++ b/Devices/DS2482_DS2484.cpp	Mon Mar 04 08:10:00 2019 -0600
@@ -222,9 +222,7 @@
     return error_code();
   }
   // Set the speed
-  Config newConfig = curConfig;
-  newConfig.set1WS(newSpeed == OverdriveSpeed);
-  return writeConfig(newConfig);
+  return writeConfig(Config(curConfig).set1WS(newSpeed == OverdriveSpeed));
 }
 
 error_code DS2482_DS2484::setLevel(Level newLevel) {
@@ -297,9 +295,7 @@
     return error_code();
   }
   // Set the level
-  Config newConfig = curConfig;
-  newConfig.setSPU(level == StrongLevel);
-  return writeConfig(newConfig);
+  return writeConfig(Config(curConfig).setSPU(level == StrongLevel));
 }
 
 error_code DS2482_DS2484::sendCommand(uint_least8_t cmd) const {
@@ -412,7 +408,7 @@
   }
 
   uint_least8_t portConfig = val + 1;
-  for (int numReads = -1; numReads < param; numReads++) {
+  for (int reads = -1; reads < param; ++reads) {
     result = readRegister(portConfig);
     if (result) {
       return result;