Darien Figueroa
/
Final_Program
Important changes to repositories hosted on mbed.com
Mbed hosted mercurial repositories are deprecated and are due to be permanently deleted in July 2026.
To keep a copy of this software download the repository Zip archive or clone locally using Mercurial.
It is also possible to export all your personal repositories from the account settings page.
pain/CodeReview/CodeReviewNotes10-27-16.txt
- Committer:
- darienf
- Date:
- 2021-05-02
- Revision:
- 5:bc128a16232f
- Parent:
- 0:832122ce6748
File content as of revision 5:bc128a16232f:
Code Review Notes
Presenter: Jerry Bradshaw
Code to be reviewed: MAXREFES100 Android App
Language: Java
Attendees:
Ben Smith
Faisal Tariq
Review Date: October 27, 2016
Review Time: 2:00pm
Action Items <Capture all action items here>
1. change the static string to const
2. DeviceScanActivity.java line 134, redundant if checks
3. DeviceScanActivity.java, missing method comments
4. change environmental to HSP in uuid definitions
5. line 203 SensorActivity.java delete click handler... not used anymore
6. line 386 ToFahrenheit method... use 0.f for values in calculation
7. magic number values line 631 on sensor activity 0x01 and 0x00
All items have been assigned to Jerry Bradshaw.
All items were completed by Jerry Bradshaw on November 3, 2016.