Team Fox / Mbed 2 deprecated RAJANGAM_REVIEW_BAE_CODE

Dependencies:   FreescaleIAP mbed-rtos mbed

Fork of QM_BAE_review_1 by Team Fox

Revision:
57:60e8f00d93c3
Parent:
56:32b1fb074138
Child:
58:c4203e162d12
--- a/TCTM.cpp	Sun Aug 07 07:49:52 2016 +0000
+++ b/TCTM.cpp	Sun Sep 04 13:08:33 2016 +0000
@@ -350,178 +350,181 @@
                                                                 telemetry[2] = ACK_CODE;
                                                                 /*random or with bcn_tx_sw_enable assuming it is 1 bit in length
                                                                 how to get that we dont know, now we just assume it to be so*/
-                                                                telemetry[3] = ACS_ATS_STATUS;
-                                                                telemetry[4] = ACS_TR_XY_SW_STATUS;
-                                                                telemetry[4] = (telemetry[4]<<2)| ACS_TR_Z_SW_STATUS;
-                                                                telemetry[4] = (telemetry[4]<<4) | ACS_STATE;
-                                                                telemetry[5] = ACS_DETUMBLING_ALGO_TYPE;
-                                                                telemetry[5] = (telemetry[5]<<2) | BCN_TX_SW_STATUS;
-                                                                telemetry[5] = (telemetry[5]<<1) | BCN_SPND_TX;
-                                                                telemetry[5] = (telemetry[5]<<1) | BCN_FEN;
-                                                                telemetry[5] = (telemetry[5]<<1) | BCN_LONG_MSG_TYPE;
-                                                                telemetry[5] = (telemetry[5]<<1) | EPS_BTRY_HTR_AUTO;//EPS_BATTERY_HEATER_ENABLE
-                                                                telemetry[5] = (telemetry[5]<<1);
-                                                                //now one spares in telemetry[5]
-                                                                telemetry[6] = BAE_RESET_COUNTER;
-                                                                
-                                                                for(int k=0;k<6;k++)
-                                                                {
-                                                                    gpc.printf("\n\rtelemetry[%d]  :  %.02X\r\n", k, telemetry[k]);
-                                                                }
+                                                                telemetry[3] = 0x00;
+                                                                telemetry[4] = ACS_ATS_STATUS;
+                                                                telemetry[5] = ACS_TR_XY_SW_STATUS;
+                                                                telemetry[5] = (telemetry[5]<<2)| ACS_TR_Z_SW_STATUS;
+                                                                telemetry[5] = (telemetry[5]<<4) | ACS_STATE;
+                                                                telemetry[6] = ACS_DETUMBLING_ALGO_TYPE;
+                                                                telemetry[6] = (telemetry[6]<<2) | BCN_TX_SW_STATUS;
+                                                                telemetry[6] = (telemetry[6]<<1) | BCN_SPND_TX;
+                                                                telemetry[6] = (telemetry[6]<<1) | BCN_FEN;
+                                                                telemetry[6] = (telemetry[6]<<1) | BCN_LONG_MSG_TYPE;
+                                                                telemetry[6] = (telemetry[6]<<1) | EPS_BTRY_HTR_AUTO;//EPS_BATTERY_HEATER_ENABLE
+                                                                telemetry[6] = (telemetry[6]<<1);
+                                                                //now one spares in telemetry[6]
+                                                                telemetry[7] = BAE_RESET_COUNTER;
+                                                                telemetry[8] = EPS_SOC_LEVEL_12; 
+                                                                telemetry[9] = EPS_SOC_LEVEL_23;
+                                                                telemetry[10] = ACS_MAG_TIME_DELAY;
+                                                                telemetry[11] = ACS_DEMAG_TIME_DELAY;
+                                                                telemetry[12] = EPS_BAT_TEMP_LOW;
+                                                                telemetry[13] = EPS_BAT_TEMP_HIGH;
+                                                                telemetry[14] = EPS_BAT_TEMP_DEFAULT;
                                                                 
-                                                                telemetry[7] = EPS_SOC_LEVEL_12; 
-                                                                telemetry[8] = EPS_SOC_LEVEL_23;
-                                                                telemetry[9] = ACS_MAG_TIME_DELAY;
-                                                                telemetry[10] = ACS_DEMAG_TIME_DELAY;
-                                                                telemetry[11] = EPS_BAT_TEMP_LOW;
-                                                                telemetry[12] = EPS_BAT_TEMP_HIGH;
-                                                                telemetry[13] = EPS_BAT_TEMP_DEFAULT;
+                                                                telemetry[15] = ACS_MM_X_COMSN >> 8;
+                                                                telemetry[16] = ACS_MM_X_COMSN;
+                                                                printf("\n\r the mm x commission %d",ACS_MM_X_COMSN);
+                                                                 
+                                                                telemetry[17] = ACS_MM_Y_COMSN >> 8;
+                                                                telemetry[18] = ACS_MM_Y_COMSN;
                                                                 
-                                                                telemetry[14] = ACS_MM_X_COMSN >> 8;
-                                                                telemetry[15] = ACS_MM_X_COMSN;
-                                                                 
-                                                                telemetry[16] = ACS_MM_Y_COMSN >> 8;
-                                                                telemetry[17] = ACS_MM_Y_COMSN;
+                                                                telemetry[19] = ACS_MG_X_COMSN >> 8;
+                                                                telemetry[20] = ACS_MG_X_COMSN;
                                                                 
-                                                                telemetry[18] = ACS_MG_X_COMSN >> 8;
-                                                                telemetry[19] = ACS_MG_X_COMSN;
-                                                                
-                                                                telemetry[20] = ACS_MG_Y_COMSN >> 8;
-                                                                telemetry[21] = ACS_MG_Y_COMSN;
+                                                                telemetry[21] = ACS_MG_Y_COMSN >> 8;
+                                                                telemetry[22] = ACS_MG_Y_COMSN;
                                                             
-                                                                telemetry[22] = ACS_MM_Z_COMSN >> 8;
-                                                                telemetry[23] = ACS_MM_Z_COMSN;
+                                                                telemetry[23] = ACS_MM_Z_COMSN >> 8;
+                                                                telemetry[24] = ACS_MM_Z_COMSN;
                                                                 
-                                                                telemetry[24] = ACS_MG_Z_COMSN >> 8;
-                                                                telemetry[25] = ACS_MG_Z_COMSN;
+                                                                telemetry[25] = ACS_MG_Z_COMSN >> 8;
+                                                                telemetry[26] = ACS_MG_Z_COMSN;
                                                                 
-                                                                telemetry[26] = ACS_Z_FIXED_MOMENT >> 8;
-                                                                telemetry[27] = ACS_Z_FIXED_MOMENT; 
+                                                                telemetry[27] = ACS_Z_FIXED_MOMENT >> 8;
+                                                                telemetry[28] = ACS_Z_FIXED_MOMENT; 
+                                                                printf("\n\r the z_fixed_moment %d",ACS_Z_FIXED_MOMENT);
+                                                                
                                                              
                                                             //BAE RAM PARAMETER
-                                                                telemetry[28] = BAE_INIT_STATUS;
-                                                                telemetry[28] = (telemetry[28]<<1) | BAE_MNG_I2C_STATUS;//changed
-                                                                telemetry[28] = (telemetry[28]<<1) | BCN_INIT_STATUS; 
-                                                                telemetry[28] = (telemetry[28]<<1) | BCN_TX_MAIN_STATUS;
-                                                                telemetry[28] = (telemetry[28]<<3) | BCN_TX_STATUS;
-                                                                telemetry[28] = (telemetry[28]<<1) | ACS_INIT_STATUS;
+                                                                telemetry[29] = BAE_INIT_STATUS;
+                                                                telemetry[29] = (telemetry[29]<<1) | BAE_MNG_I2C_STATUS;//changed
+                                                                telemetry[29] = (telemetry[29]<<1) | BCN_INIT_STATUS; 
+                                                                telemetry[29] = (telemetry[29]<<1) | BCN_TX_MAIN_STATUS;
+                                                                telemetry[29] = (telemetry[29]<<3) | BCN_TX_STATUS;
+                                                                telemetry[29] = (telemetry[29]<<1) | ACS_INIT_STATUS;
                                                                 
-                                                                telemetry[29] = ACS_DATA_ACQ_STATUS;
-                                                                telemetry[29] = (telemetry[29]<<1) | ACS_MAIN_STATUS;
-                                                                telemetry[29] = (telemetry[29]<<4) | ACS_STATUS;
-                                                                telemetry[29] = (telemetry[29]<<1) | EPS_INIT_STATUS;
+                                                                telemetry[30] = ACS_DATA_ACQ_STATUS;
+                                                                telemetry[30] = (telemetry[30]<<1) | ACS_MAIN_STATUS;
+                                                                telemetry[30] = (telemetry[30]<<4) | ACS_STATUS;
+                                                                telemetry[30] = (telemetry[30]<<1) | EPS_INIT_STATUS;
                                                                 
-                                                                telemetry[30] = EPS_BATTERY_GAUGE_STATUS;
-                                                                telemetry[30] = (telemetry[30]<<1) | EPS_MAIN_STATUS;
-                                                                telemetry[30] = (telemetry[30]<<1) | EPS_BTRY_TMP_STATUS;
-                                                                telemetry[30] = (telemetry[30]<<3) | EPS_STATUS;
-                                                                telemetry[30] = (telemetry[30]<<2) | CDMS_SW_STATUS;
+                                                                telemetry[31] = EPS_BATTERY_GAUGE_STATUS;
+                                                                telemetry[31] = (telemetry[31]<<1) | EPS_MAIN_STATUS;
+                                                                telemetry[31] = (telemetry[31]<<1) | EPS_BTRY_TMP_STATUS;
+                                                                telemetry[31] = (telemetry[31]<<3) | EPS_STATUS;
+                                                                telemetry[31] = (telemetry[31]<<2) | CDMS_SW_STATUS;
                                                         //        telemetry[30] = (telemetry[30]<<1) | EPS_BTRY_HTR_STATUS;//new to : implement
                                                                 
-                                                                telemetry[31] = EPS_BTRY_HTR;   //new to : implement
+                                                                telemetry[32] = EPS_BTRY_HTR;   //new to : implement
                                                                 //spare 4
-                                                                telemetry[31] = (telemetry[31]<<7) | BAE_STANDBY;
+                                                                telemetry[32] = (telemetry[32]<<7) | BAE_STANDBY;
                                                                 // 6 next telemetries value to be given by registers
-                                                                telemetry[32] = ATS1_EVENT_STATUS_RGTR;
-                                                                telemetry[33] = ATS1_SENTRAL_STATUS_RGTR;
-                                                                //printf("SENTRAL_STATUS is  : %.02X\r\n",ATS1_SENTRAL_STATUS_RGTR);
-                                                                telemetry[34] = ATS1_ERROR_RGTR;
-                                                                telemetry[35] = ATS2_EVENT_STATUS_RGTR;
-                                                                telemetry[36] = ATS2_SENTRAL_STATUS_RGTR;
-                                                                telemetry[37] = ATS2_ERROR_RGTR;
+                                                                telemetry[33] = ATS1_EVENT_STATUS_RGTR;
+                                                                telemetry[34] = ATS1_SENTRAL_STATUS_RGTR;
+                                                                telemetry[35] = ATS1_ERROR_RGTR;
+                                                                telemetry[36] = ATS2_EVENT_STATUS_RGTR;
+                                                                telemetry[37] = ATS2_SENTRAL_STATUS_RGTR;
+                                                                telemetry[38] = ATS2_ERROR_RGTR;
                                                                 
-                                                                telemetry[38] = BCN_FAIL_COUNT;
-                                                                telemetry[39] = actual_data.power_mode;
-                                                                telemetry[40] = HTR_CYCLE_COUNTER;//new to : implement
+                                                                telemetry[39] = BCN_FAIL_COUNT;
+                                                                telemetry[40] = actual_data.power_mode;
+                                                                telemetry[41] = HTR_CYCLE_COUNTER;//new to : implement
                                                                 
-                                                                telemetry[41] = BAE_I2C_COUNTER;
-                                                                telemetry[42] = BAE_I2C_COUNTER>>8;
-                                                                telemetry[43] = ACS_MAIN_COUNTER;
-                                                                telemetry[44] = ACS_MAIN_COUNTER>>8;
-                                                                telemetry[45] = BCN_TX_MAIN_COUNTER;
-                                                                telemetry[46] = BCN_TX_MAIN_COUNTER>>8;
-                                                                telemetry[47] = EPS_MAIN_COUNTER;
-                                                                telemetry[48] = EPS_MAIN_COUNTER>>8;
+                                                                telemetry[42] = BAE_I2C_COUNTER;
+                                                                telemetry[43] = BAE_I2C_COUNTER>>8;
+                                                                telemetry[44] = ACS_MAIN_COUNTER;
+                                                                telemetry[45] = ACS_MAIN_COUNTER>>8;
+                                                                telemetry[46] = BCN_TX_MAIN_COUNTER;
+                                                                telemetry[47] = BCN_TX_MAIN_COUNTER>>8;
+                                                                telemetry[48] = EPS_MAIN_COUNTER;
+                                                                telemetry[49] = EPS_MAIN_COUNTER>>8;
                                                                 
                                                                 uint8_t days,hours,mins;
                                                                 RETURN_UPTIME(BAE_uptime.read(),&days,&hours,&mins);
-                                                                telemetry[49] = days;
+                                                                printf("\n\r the values bae of days,hour,min %d, %d, %d",days,hours,mins);
+                                                                
+                                                                telemetry[50] = days;
                                                                 RETURN_UPTIME(I2C_last.read(),&days,&hours,&mins);
-                                                                telemetry[49] = (telemetry[49]<<3) | (hours>>2);
-                                                                telemetry[50] = hours;
-                                                                telemetry[50] = (telemetry[50]<<6) | mins;
+                                                                telemetry[50] = (telemetry[50]<<3) | (hours>>2);
+                                                                telemetry[51] = hours;
+                                                                telemetry[51] = (telemetry[51]<<6) | mins;
+                                                                
+                                                                printf("\n\r the values of bae uptime %f",BAE_uptime.read());
+                                                                printf("\n\r the values i2c of days,hour,min %d, %d, %d",days,hours,mins);
+                                                                
                                                                 
                                                                 //sending in uint can be converted back to int by direct conversion for +values
                                                                 //make sure to convert baack to int for getting negative values
                                                                 //algo for that done 
-                                                                telemetry[51] = actual_data.bit_data_acs_mm[0];
-                                                                telemetry[52] = actual_data.bit_data_acs_mm[0]>>8;
-                                                                telemetry[53] = actual_data.bit_data_acs_mm[1];
-                                                                telemetry[54] = actual_data.bit_data_acs_mm[1]>>8;
-                                                                telemetry[55] = actual_data.bit_data_acs_mm[2];
-                                                                telemetry[56] = actual_data.bit_data_acs_mm[2]>>8;
+                                                                telemetry[52] = (uint16_t)actual_data.bit_data_acs_mm[0];
+                                                                telemetry[53] = (uint16_t)actual_data.bit_data_acs_mm[0]>>8;
+                                                                telemetry[54] = (uint16_t)actual_data.bit_data_acs_mm[1];
+                                                                telemetry[55] = (uint16_t)actual_data.bit_data_acs_mm[1]>>8;
+                                                                telemetry[56] = (uint16_t)actual_data.bit_data_acs_mm[2];
+                                                                telemetry[57] = (uint16_t)actual_data.bit_data_acs_mm[2]>>8;
+                                                                printf("\n\r  the actual_data.bit_data_acs_mm[0] is %d",actual_data.bit_data_acs_mm[0]);
+                                                                printf("\n\r  the actual_data.bit_data_acs_mm[0] is %d",(uint16_t)actual_data.bit_data_acs_mm[0]);
                                                                 
-                                                                telemetry[57] = actual_data.bit_data_acs_mg[0];
-                                                                telemetry[58] = actual_data.bit_data_acs_mg[0]>>8;
-                                                                printf("MGX0 is  : %.02X \r\n",(uint8_t)actual_data.bit_data_acs_mg[0]);
-                                                                printf("MGX1 is  : %.02X \r\n",(uint8_t)(actual_data.bit_data_acs_mg[0]>>8));
-                                                                telemetry[59] = actual_data.bit_data_acs_mg[1];
-                                                                telemetry[60] = actual_data.bit_data_acs_mg[1]>>8;
-                                                                telemetry[61] = actual_data.bit_data_acs_mg[2];
-                                                                telemetry[62] = actual_data.bit_data_acs_mg[2]>>8;
+                                                                telemetry[58] = actual_data.bit_data_acs_mg[0];
+                                                                telemetry[59] = actual_data.bit_data_acs_mg[0]>>8;
+                                                                telemetry[60] = actual_data.bit_data_acs_mg[1];
+                                                                telemetry[61] = actual_data.bit_data_acs_mg[1]>>8;
+                                                                telemetry[62] = actual_data.bit_data_acs_mg[2];
+                                                                telemetry[63] = actual_data.bit_data_acs_mg[2]>>8;
                                                                 
-                                                                telemetry[63] = BCN_TX_OC_FAULT;
-                                                                telemetry[63] = (telemetry[63]<<1) | ACS_TR_XY_ENABLE;
-                                                                telemetry[63] = (telemetry[63]<<1) | ACS_TR_Z_ENABLE;
-                                                                telemetry[63] = (telemetry[63]<<1) | ACS_TR_XY_OC_FAULT;
-                                                                telemetry[63] = (telemetry[63]<<1) | ACS_TR_Z_OC_FAULT;
-                                                                telemetry[63] = (telemetry[63]<<1) | ACS_TR_XY_FAULT;
-                                                                telemetry[63] = (telemetry[63]<<1) | EPS_CHARGER_FAULT;
-                                                                telemetry[63] = (telemetry[63]<<1) | EPS_CHARGER_STATUS;
+                                                                telemetry[64] = BCN_TX_OC_FAULT;
+                                                                telemetry[64] = (telemetry[64]<<1) | ACS_TR_XY_ENABLE;
+                                                                telemetry[64] = (telemetry[64]<<1) | ACS_TR_Z_ENABLE;
+                                                                telemetry[64] = (telemetry[64]<<1) | ACS_TR_XY_OC_FAULT;
+                                                                telemetry[64] = (telemetry[64]<<1) | ACS_TR_Z_OC_FAULT;
+                                                                telemetry[64] = (telemetry[64]<<1) | ACS_TR_XY_FAULT;
+                                                                telemetry[64] = (telemetry[64]<<1) | EPS_CHARGER_FAULT;
+                                                                telemetry[64] = (telemetry[64]<<1) | EPS_CHARGER_STATUS;
                                                                 
-                                                                telemetry[64] = EPS_BATTERY_GAUGE_ALERT;
-                                                                telemetry[64] = (telemetry[64]<<1) | CDMS_OC_FAULT;
-                                                                telemetry[64] = (telemetry[64]<<1) | ACS_ATS1_OC_FAULT;
-                                                                telemetry[64] = (telemetry[64]<<1) | ACS_ATS2_OC_FAULT;
-                                                                telemetry[64] = (telemetry[64]<<1) | ACS_TR_Z_FAULT;
-                                                                telemetry[64] = (telemetry[64]<<3);
+                                                                telemetry[65] = EPS_BATTERY_GAUGE_ALERT;
+                                                                telemetry[65] = (telemetry[65]<<1) | CDMS_OC_FAULT;
+                                                                telemetry[65] = (telemetry[65]<<1) | ACS_ATS1_OC_FAULT;
+                                                                telemetry[65] = (telemetry[65]<<1) | ACS_ATS2_OC_FAULT;
+                                                                telemetry[65] = (telemetry[65]<<1) | ACS_TR_Z_FAULT;
+                                                                telemetry[65] = (telemetry[65]<<3);
                                                                 //3 spare
                                                                 
-                                                                telemetry[65] = ACS_TR_X_PWM;
-                                                                telemetry[66] = ACS_TR_Y_PWM;
-                                                                telemetry[67] = ACS_TR_Z_PWM;
+                                                                telemetry[66] = ACS_TR_X_PWM;
+                                                                telemetry[67] = ACS_TR_Y_PWM;
+                                                                telemetry[68] = ACS_TR_Z_PWM;
                                                                 //spare byte
                                                                 //assigned it to counter HTR_CYCLE_COUNTER
                                                                 
                                                                 //assign it b_scz_angle
-                                                                telemetry[68] = B_SCZ_ANGLE>>4; 
-                                                                telemetry[68] = (telemetry[68]<<1) | alarmmode;
-                                                                telemetry[68] = (telemetry[68]<<1) | controlmode_mms;
-                                                                telemetry[68] = (telemetry[68]<<1) | singularity_flag_mms;
-                                                                telemetry[68] = (telemetry[68]<<1);
+                                                                telemetry[69] = B_SCZ_ANGLE>>4; 
+                                                                telemetry[69] = (telemetry[69]<<1) | alarmmode;
+                                                                telemetry[69] = (telemetry[69]<<1) | controlmode_mms;
+                                                                telemetry[69] = (telemetry[69]<<1) | singularity_flag_mms;
+                                                                telemetry[69] = (telemetry[69]<<1);
                                                                 //1 bit spare
                                                                 
                                                                 for(int i=0;i<9;i++)
                                                                 {
-                                                                    telemetry[69+i] =  invjm_mms[i];
-                                                                    telemetry[80+i] =  jm_mms[i];
+                                                                    telemetry[70+i] =  invjm_mms[i];
+                                                                    telemetry[81+i] =  jm_mms[i];
                                                                 }
                                                                 
                                                                 for(int i=1;i<3;i++)
-                                                                telemetry[78+i] = bb_mms[i];
+                                                                telemetry[79+i] = bb_mms[i];
                                                                 
                                                                 for(int i=0;i<16;i++)
                                                                 {
-                                                                    telemetry[89+i] = quant_data.voltage_quant[i];
-                                                                    telemetry[105+i] = quant_data.current_quant[i];
+                                                                    telemetry[90+i] = quant_data.voltage_quant[i];
+                                                                    telemetry[106+i] = quant_data.current_quant[i];
                                                                 }
                                                                 
-                                                                telemetry[121] = quant_data.Batt_voltage_quant;
-                                                                telemetry[122] = quant_data.BAE_temp_quant;
-                                                                telemetry[123] = (uint8_t)(actual_data.Batt_gauge_actual[1]);
-                                                                telemetry[124] = quant_data.Batt_temp_quant[0];
-                                                                telemetry[125] = quant_data.Batt_temp_quant[1];
-                                                                telemetry[126] = BCN_TMP;
+                                                                telemetry[122] = quant_data.Batt_voltage_quant;
+                                                                telemetry[123] = quant_data.BAE_temp_quant;
+                                                                telemetry[124] = (uint8_t)(actual_data.Batt_gauge_actual[1]);
+                                                                telemetry[125] = quant_data.Batt_temp_quant[0];
+                                                                telemetry[126] = quant_data.Batt_temp_quant[1];
+                                                                telemetry[127] = BCN_TMP;
                                                                 
                                                                 //*  ANY USE?
                                                                 ///if(BCN_TX_STATUS==2)
@@ -535,101 +538,96 @@
                                                                 ///for(int i=0; i<3; i++)
                                                                 ///    FCTN_CONVERT_FLOAT((float)actual_data.AngularSpeed_actual[i],&telemetry[38+(i*4)]);
                                                                 ///    
-                                                                for (int i=127; i<132;i++)
+                                                                for (int i=128; i<132;i++)
                                                                     {
                                                                         telemetry[i] = 0x00;
                                                                     }
-                                                                
                                                                 crc16 = CRC::crc16_gen(telemetry,132);
                                                                 telemetry[132] = (uint8_t)((crc16&0xFF00)>>8);
                                                                 telemetry[133] = (uint8_t)(crc16&0x00FF);
-                                                                //for(int j=0;j<=133;j++)
-                                                                //{
-                                                                    //printf("Telemetry[%d]  : %.02X\r\n",j, telemetry[j]);
-                                                               //}
-                                                               gpc.printf("\n\rCRC  :  %.02X %.02X\r\n", telemetry[132],telemetry[133]);
                                     
                                                                 break;
                                                             }
                                                     case 0x0001:
                                                             {
                                                                 gpc.printf("\r\nhk data tm");
-                                                                telemetry[0] = 0x30;
+                                                                telemetry[0] = 0x30; // changed0x06 shifted by 1 bit 0x03
                                                                 telemetry[1] = tc[0];
                                                                 telemetry[2] = ACK_CODE;
+                                                                telemetry[3] = 0x00;
 
                                                                 for(int i;i<16;i++)
                                                                 {
-                                                                    telemetry[i+3] = bae_HK_minmax.voltage_max[i];
-                                                                    telemetry[i+19] = bae_HK_minmax.current_max[i];
+                                                                    telemetry[i+4] = bae_HK_minmax.voltage_max[i];
+                                                                    telemetry[i+20] = bae_HK_minmax.current_max[i];
                                                                 }
                                     
-                                                                telemetry[35] = bae_HK_minmax.Batt_voltage_max;
-                                                                telemetry[36] = bae_HK_minmax.BAE_temp_max;
+                                                                telemetry[36] = bae_HK_minmax.Batt_voltage_max;
+                                                                telemetry[37] = bae_HK_minmax.BAE_temp_max;
                                     
-                                                                telemetry[37] = bae_HK_minmax.Batt_SOC_max;
+                                                                telemetry[38] = bae_HK_minmax.Batt_SOC_max;
                                     
-                                                                telemetry[38] = bae_HK_minmax.Batt_temp_max[0];                                 
-                                                                telemetry[39] = bae_HK_minmax.Batt_temp_max[1];
+                                                                telemetry[39] = bae_HK_minmax.Batt_temp_max[0];                                 
+                                                                telemetry[40] = bae_HK_minmax.Batt_temp_max[1];
                                     
                                                                 /*BCN  temp there*/
-                                                                telemetry[40] = bae_HK_minmax.BCN_TEMP_max;
+                                                                telemetry[41] = bae_HK_minmax.BCN_TEMP_max;
                                     
                                                                 for(int i=0; i<3; i++)
                                                                 {
-                                                                    telemetry[41+(2*i)] = (bae_HK_minmax.bit_data_acs_mm_max[i]>>8);
-                                                                    telemetry[42+(2*i)] = bae_HK_minmax.bit_data_acs_mm_max[i];
+                                                                    telemetry[42+(2*i)] = (bae_HK_minmax.bit_data_acs_mm_max[i]>>8);
+                                                                    telemetry[43+(2*i)] = bae_HK_minmax.bit_data_acs_mm_max[i];
                                                                     
-                                                                    telemetry[47+(2*i)] = (bae_HK_minmax.bit_data_acs_mg_max[i]>>8);
-                                                                    telemetry[48+(2*i)] = bae_HK_minmax.bit_data_acs_mg_max[i];
+                                                                    telemetry[48+(2*i)] = (bae_HK_minmax.bit_data_acs_mg_max[i]>>8);
+                                                                    telemetry[49+(2*i)] = bae_HK_minmax.bit_data_acs_mg_max[i];
                                                                 }       
                                     
                                                                 /*min data*/
                                     
                                                                 for(int i;i<16;i++)
-                                                                    telemetry[i+53] = bae_HK_minmax.voltage_min[i];
+                                                                    telemetry[i+54] = bae_HK_minmax.voltage_min[i];
                                     
                                                                 for(int i;i<16;i++)
-                                                                    telemetry[i+69] = bae_HK_minmax.current_min[i];
+                                                                    telemetry[i+70] = bae_HK_minmax.current_min[i];
                                     
-                                                                telemetry[85] = bae_HK_minmax.Batt_voltage_min;
-                                                                telemetry[86] = bae_HK_minmax.BAE_temp_min;
+                                                                telemetry[86] = bae_HK_minmax.Batt_voltage_min;
+                                                                telemetry[87] = bae_HK_minmax.BAE_temp_min;
                                     
                                                                 /*battery soc*/
-                                                                telemetry[87] = bae_HK_minmax.Batt_SOC_min;
+                                                                telemetry[88] = bae_HK_minmax.Batt_SOC_min;
                                     
-                                                                telemetry[88] = bae_HK_minmax.Batt_temp_min[0];
-                                                                telemetry[89] = bae_HK_minmax.Batt_temp_min[1];
+                                                                telemetry[89] = bae_HK_minmax.Batt_temp_min[0];
+                                                                telemetry[90] = bae_HK_minmax.Batt_temp_min[1];
                                                                 //huhu//
                                     
                                                                 /*BCN  temp named as BCN_TS_BUFFER there*/
-                                                                telemetry[90] = bae_HK_minmax.BCN_TEMP_min;
+                                                                telemetry[91] = bae_HK_minmax.BCN_TEMP_min;
                                     
                                                                 for(int i=0; i<3; i++)
                                                                 {
-                                                                    telemetry[91+(2*i)] = (bae_HK_minmax.bit_data_acs_mm_min[i]>>8);
-                                                                    telemetry[92+(2*i)] = bae_HK_minmax.bit_data_acs_mm_min[i];
+                                                                    telemetry[92+(2*i)] = (bae_HK_minmax.bit_data_acs_mm_min[i]>>8);
+                                                                    telemetry[93+(2*i)] = bae_HK_minmax.bit_data_acs_mm_min[i];
                                                                     
-                                                                    telemetry[97+(2*i)] =  (bae_HK_minmax.bit_data_acs_mg_min[i]>>8);
-                                                                    telemetry[98+(2*i)] =  bae_HK_minmax.bit_data_acs_mg_min[i];
+                                                                    telemetry[98+(2*i)] =  (bae_HK_minmax.bit_data_acs_mg_min[i]>>8);
+                                                                    telemetry[99+(2*i)] =  bae_HK_minmax.bit_data_acs_mg_min[i];
                                                                 }       
                                                                   
-                                                                telemetry[103] = BCN_TX_OC_FAULT;
-                                                                telemetry[103] = (telemetry[103]<<1) | ACS_TR_XY_OC_FAULT;
-                                                                telemetry[103] = (telemetry[103]<<1) | ACS_TR_Z_OC_FAULT;
-                                                                telemetry[103] = (telemetry[103]<<1) | ACS_TR_XY_FAULT;
+                                                                telemetry[104] = BCN_TX_OC_FAULT;
+                                                                telemetry[104] = (telemetry[104]<<1) | ACS_TR_XY_OC_FAULT;
+                                                                telemetry[104] = (telemetry[104]<<1) | ACS_TR_Z_OC_FAULT;
+                                                                telemetry[104] = (telemetry[104]<<1) | ACS_TR_XY_FAULT;
                                                                 //EPS CHARGER
-                                                                telemetry[103] = (telemetry[103]<<1) | EPS_CHARGER_FAULT;//eps_charger;
-                                                                telemetry[103] = (telemetry[103]<<1) | CDMS_OC_FAULT;
-                                                                telemetry[103] = (telemetry[103]<<1) | ACS_ATS1_OC_FAULT;
-                                                                telemetry[103] = (telemetry[103]<<1) | ACS_ATS2_OC_FAULT;
+                                                                telemetry[104] = (telemetry[104]<<1) | EPS_CHARGER_FAULT;//eps_charger;
+                                                                telemetry[104] = (telemetry[104]<<1) | CDMS_OC_FAULT;
+                                                                telemetry[104] = (telemetry[104]<<1) | ACS_ATS1_OC_FAULT;
+                                                                telemetry[104] = (telemetry[104]<<1) | ACS_ATS2_OC_FAULT;
                                                                 
-                                                                telemetry[104] = (ACS_TR_Z_FAULT<<7);
+                                                                telemetry[105] = (ACS_TR_Z_FAULT<<7);
                                                                 //spare 23 bits
-                                                                telemetry[105] = 0x00;
                                                                 telemetry[106] = 0x00;
+                                                                telemetry[107] = 0x00;
                                                                 
-                                                                for (int i=107; i<132;i++)
+                                                                for (int i=108; i<132;i++)
                                                                     {
                                                                         telemetry[i] = 0x00;
                                                                     }
@@ -641,7 +639,7 @@
                                                     default://invalid MID
                                                             {
                                                                 //ACK_L234_telemetry
-                                                                telemetry[0]=0xB0;
+                                                                telemetry[0]=0xB0; // check if this needs to be changed
                                                                 telemetry[1]=tc[0];
                                                                 telemetry[2]=0x02;//for this case
                                                                 for(uint8_t i=3;i<11;i++)
@@ -659,7 +657,7 @@
                                                             }
                                                  }
                                                 break;
-                                            }
+                                            } 
                                     case 0x05:
                                             {
                                                 gpc.printf("\n\rdata for mms 0x05 flash");