Lancaster University / mbed-src

Lancaster University's (short term!) clone of mbed-src for micro:bit. This is a copy of the github branch https://github.com/lancaster-university/mbed-classic

Fork of mbed-src by mbed official

common/Ticker.cpp@641:be9b2017785a, 2016-07-13 (annotated)

Committer:
LancasterUniversity
Date:
Wed Jul 13 12:52:54 2016 +0100
Revision:
641:be9b2017785a
Parent:
525:c320967f86b9 
Synchronized with git rev 1fb8ab4c

Author: James Devine

mbed-classic: BUGFIX for timer when using wait_ms from interrupt context



Previously if a user used wait[_ms,_us] in interrupt context the device would

hang indefinitely. This was due to incrementing overflowCount from

interrupt context only.



This meant that if a user used wait[_ms,_us] in an ISR with

the same or greater interrupt priority, it would result in an infinite

loop as the overflowCount variable would never be incremented, and

wait[_ms,_us] would never return.



This patch simply applies a better solution for the race condition

mentioned in the previous commit. It instead disables the timer1

interrupt and increments the overflowCount variable, preventing

the race condition whilst supporting wait[_ms,_us] in interrupt

context.

Who changed what in which revision?

UserRevisionLine numberNew contents of line
bogdanm 13:0645d8841f51 1 /* mbed Microcontroller Library
bogdanm 13:0645d8841f51 2 * Copyright (c) 2006-2013 ARM Limited
bogdanm 13:0645d8841f51 3 *
bogdanm 13:0645d8841f51 4 * Licensed under the Apache License, Version 2.0 (the "License");
bogdanm 13:0645d8841f51 5 * you may not use this file except in compliance with the License.
bogdanm 13:0645d8841f51 6 * You may obtain a copy of the License at
bogdanm 13:0645d8841f51 7 *
bogdanm 13:0645d8841f51 8 * http://www.apache.org/licenses/LICENSE-2.0
bogdanm 13:0645d8841f51 9 *
bogdanm 13:0645d8841f51 10 * Unless required by applicable law or agreed to in writing, software
bogdanm 13:0645d8841f51 11 * distributed under the License is distributed on an "AS IS" BASIS,
bogdanm 13:0645d8841f51 12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
bogdanm 13:0645d8841f51 13 * See the License for the specific language governing permissions and
bogdanm 13:0645d8841f51 14 * limitations under the License.
bogdanm 13:0645d8841f51 15 */
bogdanm 13:0645d8841f51 16 #include "Ticker.h"
bogdanm 13:0645d8841f51 17
bogdanm 13:0645d8841f51 18 #include "TimerEvent.h"
bogdanm 13:0645d8841f51 19 #include "FunctionPointer.h"
mbed_official 525:c320967f86b9 20 #include "ticker_api.h"
bogdanm 13:0645d8841f51 21
bogdanm 13:0645d8841f51 22 namespace mbed {
bogdanm 13:0645d8841f51 23
bogdanm 13:0645d8841f51 24 void Ticker::detach() {
bogdanm 13:0645d8841f51 25 remove();
mbed_official 36:ab3ee77451e7 26 _function.attach(0);
bogdanm 13:0645d8841f51 27 }
bogdanm 13:0645d8841f51 28
mbed_official 304:89b9c3a9a045 29 void Ticker::setup(timestamp_t t) {
bogdanm 13:0645d8841f51 30 remove();
bogdanm 13:0645d8841f51 31 _delay = t;
mbed_official 525:c320967f86b9 32 insert(_delay + ticker_read(_ticker_data));
bogdanm 13:0645d8841f51 33 }
bogdanm 13:0645d8841f51 34
bogdanm 13:0645d8841f51 35 void Ticker::handler() {
bogdanm 13:0645d8841f51 36 insert(event.timestamp + _delay);
mbed_official 36:ab3ee77451e7 37 _function.call();
bogdanm 13:0645d8841f51 38 }
bogdanm 13:0645d8841f51 39
bogdanm 13:0645d8841f51 40 } // namespace mbed