5 years, 3 months ago.

Why isn't the patch number updated?

I have tried to synchronize my offline mbed-os library with the one used by the online compiler = Mbed OS 5.13.3, revision 808c45062f94:

A:\src\arm\mbed\mbed-os>mbed update 808c45062f94
[mbed] Working path "A:\src\arm\mbed\mbed-os" (program)
[mbed] Updating program "mbed-os" to rev #808c45062f94 (tags: latest, mbed-os-5.13.3)

However, the patch number in the mbed_version.h file wasn't updated correctly:

/* mbed Microcontroller Library
 * Copyright (c) 2018 ARM Limited
 * SPDX-License-Identifier: Apache-2.0
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

#ifndef MBED_VERSION_H
#define MBED_VERSION_H

/** MBED_MAJOR_VERSION
  * Mbed OS major version
  *
  * @note 99 is default value for development version (master branch)
  */
#define MBED_MAJOR_VERSION 5

/** MBED_MINOR_VERSION
  * Mbed OS minor version
  *
  * @note 99 is default value for development version (master branch)
  */
#define MBED_MINOR_VERSION 13

/** MBED_PATCH_VERSION
  * Mbed OS patch version
  *
  * @note 99 is default value for development version (master branch)
  */
#define MBED_PATCH_VERSION 2

#define MBED_ENCODE_VERSION(major, minor, patch) ((major)*10000 + (minor)*100 + (patch))

/** MBED_VERSION
  * Mbed OS 5 version (MMmmpp - M(Major); m(minor); p(patch))
  *
  * @note 999999 is default value for development version (master branch)
  */
#define MBED_VERSION MBED_ENCODE_VERSION(MBED_MAJOR_VERSION, MBED_MINOR_VERSION, MBED_PATCH_VERSION)

/** MBED_VERSION_CHECK
  * Macro can be used to check minimum Mbed OS version required for feature/library. If current version
  * is less than required, it will assert.
  *
  * @note: Version of master branch will be 999999 as default, hence no assert/warning is provided for
  * master branch code
  */
#define MBED_VERSION_CHECK(major, minor, patch) do { \
                                       MBED_STATIC_ASSERT((MBED_VERSION >= MBED_ENCODE_VERSION((major),(minor),(patch))), "Incompatible mbed-os version detected!!"); \
                                     } while(0)

#endif

/** @}*/
/** @}*/

Is it because this issue hasn't been fixed yet?

Question relating to:

Hi, just a follow-up, Mbed OS 5.13.4 is released, and I think the revision is updated correctly.

posted by Desmond Chen 29 Aug 2019

1 Answer

5 years, 3 months ago.

Hi Zoltan,

Thank you for reporting this, we are aware of this mistake and already make it announced in our release page. https://os.mbed.com/mbed-os/releases/

Regards, Desmond

Accepted Answer

Yes, it works. Thank you!

posted by Zoltan Hudak 31 Aug 2019