Andrew Boyson / web

Common stuff for all my devices' web server pages: css, login, log, ipv4, ipv6, firmware update, clock, reset info etc.

Dependents:   oldheating gps motorhome heating

Security

A password has to be set whenever there has been a software reset. Resets following faults or power on do not require a new password as the hash is restored from the RTC GPREG register.

The password is not saved on the device; instead a 32 bit hash of the password is saved. It would take 2^31 attempts to brute force the password: this could be done in under a month if an attempt were possible every millisecond. To prevent this a 200 ms delay is introduced in the reply to the login form, that gives a more reasonable 13 years to brute force the password.

Once the password is accepted a random session id is created. This is 36 bit to give six base 64 characters but without an extra delay. If an attempt could be made every ms then this would still take over a year to brute force.

The most likely attack would to use a dictionary with, say, 10 million entries against the password which would still take 20 days to do.

Diff: web.c

Revision:
123:06de83222fda
Parent:
122:cd3f391ac8aa
Child:
125:772948168e4f
diff -r cd3f391ac8aa -r 06de83222fda web.c
--- a/web.c	Sun May 12 17:18:19 2019 +0000
+++ b/web.c	Tue May 14 15:10:29 2019 +0000
@@ -116,14 +116,13 @@
     if (!pState->postComplete) handlePost(pState->toDo, contentLength, contentStart, size, pRequestStream, positionInRequestStream, &pState->postComplete);
 }
 
-static int sendReply(char* pStateData)
+static bool sendReply(char* pStateData, bool clientFinished)
 {
     struct state* pState = (struct state*)pStateData;
     
-    //0: not started; +1: started; -1: wait
-    if (!pState->toDo                       ) return  0; //return not started
-    if (!pState->postComplete               ) return -1; //return started but without adding any data
-    if (!MsTimerAbsolute(pState->delayUntil)) return -1; //return started but without adding any data
+    if (!pState->toDo                       ) return clientFinished; //If the client has never sent anything and has finished then finish
+    if (!pState->postComplete               ) return false;
+    if (!MsTimerAbsolute(pState->delayUntil)) return false;
     
     int todo = pState->toDo; //Make a copy so that we don't modify todo in the state
 
@@ -144,13 +143,13 @@
     
     reply(todo);
     
-    return +1; //return started after adding data
+    return !HttpBufFilled(); //If we haven't used a full buffer then we have finished
 }
 
 int WebInit()
 {
     HttpRequestFunction = handleRequest;
-    HttpReplyFunction   = sendReply;
+    HttpReplyPollFunction   = sendReply;
     
     WebLoginInit();